since stuff isn't deploying, did a bunch of code cleanup and logging

bot.js

@@ -11,6 +11,7 @@ var channel = null;
 
 // available commands
 function availableCommands() {
+    console.log('availaleCommands called.');
     return "Available commands: " +
         "\n**[SFW]** b.<*coinflip, 8ball, roll, compute, summon, bunny, dankmemes, meirl, animemes, moe, moe-boys, hotguys , kgirls, kboys*>" +
         "\n**[NSFW]** b.<*lewd, ecchi, hentai, yaoi, yuri, neko, pokeporn, hgifs*>" +
@@ -19,7 +20,8 @@ function availableCommands() {
 
 // help commands
 function commandsHelp(requestedCommand) {
-    var commands = {
+    console.log('commandsHelp called.');
+    let commands = {
         "coinflip": "**coinflip:** Returns a result of heads or tails.",
         "8ball": "**8ball:** Shakes an 8 ball and returns a result.",
         "roll": "**roll:** Rolls a number between 1-100 (or a specified range [ex: b.roll 50-100])",
@@ -46,21 +48,32 @@ function commandsHelp(requestedCommand) {
     };
 
     if (commands[requestedCommand] === undefined) {
+        console.log('requestedCommand not found in map.');
         return "Command not found, try entering **b.commands** for a full list of commands";
     }
     else {
+        console.log('requestedCommand found, returning requestedCommand map entry.');
         return commands[requestedCommand];
     }
 }
 
+// For now abstracting this, so we can maybe use config later.
+// content should be a string or something js thinks is a string :)
+function sendToBotTestingChannel(content) {
+    console.log(content);
+    client.channels.get('357365312620068874').send(content);
+}
+
 // coin flip
 function coinFlip() {
+    console.log('coinFlip called.');
     return (Math.floor(Math.random() * 2) === 0) ? 'heads' : 'tails';
 }
 
 // 8 ball
 function eightBall() {
-    var answers = [
+    console.log('eightBall called.');
+    let answers = [
         'Maybe.', 'Certainly not.', 'I hope so.', 'Not in your wildest dreams.',
         'There is a good chance.', 'Quite likely.', 'I think so.', 'I hope not.',
         'I hope so.', 'Never!', 'Fuhgeddaboudit.', 'Ahaha! Really?!?', 'Pfft.',
@@ -75,11 +88,14 @@ function eightBall() {
 function numberRoll(startingRange, endingRange) {
     startingRange = Math.ceil(startingRange);
     endingRange = Math.floor(endingRange);
+
+    console.log('numberRoll called. rolling a number inbetween ' + startingRange + ' and ' + endingRange);
     return Math.floor(Math.random() * (endingRange - startingRange)) + startingRange;
 }
 
 // stupid question response
 function stupidQuestion() {
+    console.log('someone asked a stupid question.');
     let answers = [
         'What kind of dumb question is that?', 'A real question please.',
         'Is that supposed to be a question?', 'Who asked such a dumb question?',
@@ -90,6 +106,7 @@ function stupidQuestion() {
 }
 
 function noQuestion() {
+    console.log('no question was asked.');
     let answers = ['it helps to ask a question...', 'question plz.', 'where is the question?'];
 
     return answers[(Math.floor(Math.random() * answers.length))];
@@ -102,41 +119,49 @@ function noQuestion() {
 function bestEffortRequest(subpage, page_max) {
 
     let reddit_response = asyncSiteRequest("https://www.reddit.com/r/" + subpage + "/.json?show=all&count=25&limit=100", handleRedditJson);
-    if(reddit_response) { return reddit_response; }
+    if (reddit_response) {
+        return reddit_response;
+    }
 
     let imgur_response;
     if (page_max) {
         imgur_response = imgurRequest(subpage, page_max);
-        if(imgur_response) { return imgur_response }
+        if (imgur_response) {
+            return imgur_response
+        }
     }
 
     let redditbooru_response = redditbooruRequest(subpage);
-    if(redditbooru_response) { return redditbooru_response }
+    if (redditbooru_response) {
+        return redditbooru_response
+    }
 
-    client.channels.get('357365312620068874').send('reddit:' + reddit_response + '\nimgur:' + imgur_response + '\nredditbooru:' + redditbooru_response);
+    sendToBotTestingChannel('reddit:' + reddit_response + '\nimgur:' + imgur_response + '\nredditbooru:' + redditbooru_response);
 
     return "I couldn't find that, sauce?";
 }
 
 // imgur request
 function imgurRequest(subreddit, page_max) {
-    var multiSubreddit = subreddit.split(',');
+    let multiSubreddit = subreddit.split(',');
 
-    var request_url = 'https://api.imgur.com/3/gallery/r/' + multiSubreddit[getRandomInt(0, multiSubreddit.length - 1)] + '/time/' + getRandomInt(1, page_max);
+    let request_url = 'https://api.imgur.com/3/gallery/r/' + multiSubreddit[getRandomInt(0, multiSubreddit.length - 1)] + '/time/' + getRandomInt(1, page_max);
 
-    var req = new XMLHttpRequest();
+    let req = new XMLHttpRequest();
-    var returnText = "";
+    let returnText = "";
 
     req.onreadystatechange = function () {
         if (req.readyState === 4 && req.status === 200) {
             if (req.responseText !== "Not found") {
                 try {
-                    var json = JSON.parse(req.responseText);
+                    let json = JSON.parse(req.responseText);
                     let json_data = json.data[getRandomInt(0, json.data.length - 1)];
-                    if(json_data) { returnText = json_data.link; }
+                    if (json_data) {
+                        returnText = json_data.link;
+                    }
                 } catch (error) {
                     // Ignore the error and let the calling method handle the empty string.
-                    client.channels.get('357365312620068874').send(error.message);
+                    sendToBotTestingChannel(error.message);
                 }
             }
         }
@@ -152,7 +177,7 @@ function imgurRequest(subreddit, page_max) {
 // Abstracted Reddit Json media grab.
 function handleRedditJson(data) {
     let json = data.json();
-    for(i = 0; i < json.data.children.length; i++) {
+    for (let i = 0; i < json.data.children.length; i++) {
         let rand = getRandomInt(0, json.data.children.length - 1);
 
         if (json.data.children[rand].data.post_hint === "image" || json.data.children[rand].data.post_hint === "link" || json.data.children.data.post_hint === "rich:video") {
@@ -167,29 +192,33 @@ function handleRedditJson(data) {
 function asyncSiteRequest(url, process) {
 
     fetch(url)
-        .then(data => {return process(data);})
+        .then(data => {
+            return process(data);
+        })
         .catch(error => {
-            client.channels.get('357365312620068874').send(error.message);
+            sendToBotTestingChannel(error.message);
-            return ""; })
+            console.log(error.message);
+            return "";
+        })
 }
 
 // subreddit request
 function subredditRequest(subreddit) {
-    var multiSubreddit = subreddit.split(',');
+    let multiSubreddit = subreddit.split(',');
 
-    var redditURL = "https://www.reddit.com/r/" + multiSubreddit[getRandomInt(0, multiSubreddit.length - 1)] + "/.json?show=all&count=25&limit=100";
+    let redditURL = "https://www.reddit.com/r/" + multiSubreddit[getRandomInt(0, multiSubreddit.length - 1)] + "/.json?show=all&count=25&limit=100";
-    var req = new XMLHttpRequest();
+    let req = new XMLHttpRequest();
-    var returnText = "";
+    let returnText = "";
 
     req.onreadystatechange = function () {
         if (req.readyState === 4 && req.status === 200) {
 
-            var json = JSON.parse(req.responseText);
+            let json = JSON.parse(req.responseText);
 
             let counter = 0;
 
             while (true) {
-                var i = getRandomInt(0, json.data.children.length - 1);
+                let i = getRandomInt(0, json.data.children.length - 1);
                 try {
 
                     counter++;
@@ -203,10 +232,12 @@ function subredditRequest(subreddit) {
                 {
                     // Ignore the error and continue.
                     // continue; <-- last line in the loop... so does nothing.
-                    client.channels.get('357365312620068874').send(error.message);
+                    sendToBotTestingChannel(error.message);
                 }
 
-                if(counter > 5) { break; }g
+                if (counter > 5) {
+                    break;
+                }
             }
         }
     };
@@ -219,16 +250,16 @@ function subredditRequest(subreddit) {
 
 // redditbooru request
 function redditbooruRequest(subreddit) {
-    var multiSubreddit = subreddit.split(',');
+    let multiSubreddit = subreddit.split(',');
 
-    var url = "https://" + multiSubreddit[getRandomInt(0, multiSubreddit.length - 1)] + ".redditbooru.com/images/?limit=1000";
+    let url = "https://" + multiSubreddit[getRandomInt(0, multiSubreddit.length - 1)] + ".redditbooru.com/images/?limit=1000";
-    var req = new XMLHttpRequest();
+    let req = new XMLHttpRequest();
-    var returnText = "";
+    let returnText = "";
 
     req.onreadystatechange = function () {
         if (req.readyState === 4 && req.status === 200) {
-            var json = JSON.parse(req.responseText);
+            let json = JSON.parse(req.responseText);
-            var imageID = getRandomInt(0, json.length);
+            let imageID = getRandomInt(0, json.length);
             returnText = json[imageID].cdnUrl;
         }
     };
@@ -241,9 +272,9 @@ function redditbooruRequest(subreddit) {
 
 // wolframalpha computation
 function calculate(message) {
-    var url = "http://api.wolframalpha.com/v1/result?appid=" + auth.wolframalpha + "&i=" + encodeURIComponent(message);
+    let url = "http://api.wolframalpha.com/v1/result?appid=" + auth.wolframalpha + "&i=" + encodeURIComponent(message);
-    var req = new XMLHttpRequest();
+    let req = new XMLHttpRequest();
-    var returnText = "";
+    let returnText = "";
 
     req.onreadystatechange = function () {
         if (req.readyState === 4 && req.status === 200) {
@@ -273,8 +304,7 @@ function setupVoice(file, volume, voice_channel) {
     if (channel instanceof Discord.VoiceChannel) {
         if (!queueExists) {
             queueExists = true;
-            channel.join().then(connection =>
+            channel.join().then(connection => {
-            {
                 handlePlayQueue(connection);
             });
         }
@@ -292,10 +322,9 @@ function handlePlayQueue(connection) {
         return;
     }
 
-    currentCommand = playQueue[0];
+    let currentCommand = playQueue[0];
-    const dispatcher = connection.playFile(currentCommand)
+    const dispatcher = connection.playFile(currentCommand);
-    dispatcher.on("end", () =>
+    dispatcher.on("end", () => {
-    {
         playQueue.pop();
         playVolume.pop();
 
@@ -318,44 +347,49 @@ function handlePlayQueue(connection) {
 const client = new Discord.Client();
 
 client.on('ready', () => {
+
     console.log('Bot is ready');
 
     // update status
-var availableTypes = ['PLAYING', 'LISTENING', 'WATCHING'];
+    let availableTypes = ['PLAYING', 'LISTENING', 'WATCHING'];
-var setType = availableTypes[Math.floor(Math.random() * availableTypes.length)];
+    let setType = availableTypes[Math.floor(Math.random() * availableTypes.length)];
-var setStatus;
+    let setStatus;
+    let availableStatus;
 
     switch (setType) {
         case 'PLAYING':
-        var availableStatus = ['with cute bunnies', 'with bunny toys', 'in bunny heaven', 'with my pet bunny', 'with all the bunnies'];
+            availableStatus = ['with cute bunnies', 'with bunny toys', 'in bunny heaven', 'with my pet bunny', 'with all the bunnies'];
-        setStatus = availableStatus[Math.floor(Math.random() * availableStatus.length)];
             break;
         case 'LISTENING':
-        var availableStatus = ['to cute bunnies', 'to adorable bunnies eating', 'to bunnies playing with toys', 'to bunnies pouting'];
+            availableStatus = ['to cute bunnies', 'to adorable bunnies eating', 'to bunnies playing with toys', 'to bunnies pouting'];
-        setStatus = availableStatus[Math.floor(Math.random() * availableStatus.length)];
             break;
         case 'WATCHING':
-        var availableStatus = ['cute bunnies', 'cute bunnies play', 'cute bunnies sleep', 'bunnies nibbling on food', 'swiftimustv'];
+            availableStatus = ['cute bunnies', 'cute bunnies play', 'cute bunnies sleep', 'bunnies nibbling on food', 'swiftimustv'];
-        setStatus = availableStatus[Math.floor(Math.random() * availableStatus.length)];
             break;
     }
+    setStatus = availableStatus[Math.floor(Math.random() * availableStatus.length)];
 
-client.user.setActivity(setStatus, {type: setType});
+    // todo this set activity returns a promise and we aren't doing anything with it
+    client.user.setActivity(setStatus, {type: setType})
+        .catch(error => {
+            sendToBotTestingChannel(error.message);
+            console.log(error.message);
+        });
 })
 ;
 
 // commands
 client.on('message', message => {
-    if(message.content.substring(0, 2).toUpperCase() === 'B.') {
+    if (message.content.substring(0, 2).toUpperCase() === 'B.' || message.content.substring(0, 2) === '//') {
-    var args = message.content.substring(2).split(' ');
+        let args = message.content.substring(2).split(' ');
-    var cmd = args[0];
+        let cmd = args[0];
 
         switch (cmd) {
             // Reply commands
             case 'command':
             case 'commands':
             case 'help':
-            var message_content = message.content.substring(2).split(' ');
+                let message_content = message.content.substring(2).split(' ');
                 if (message.content.substring(2).split(' ')[1] === undefined) {
                     message.channel.send(availableCommands());
                 }
@@ -377,12 +411,12 @@ client.on('message', message => {
                 }
                 break;
             case 'roll':
-            var message_content = message.content.substring(2).split(' ');
+                let message_content = message.content.substring(2).split(' ');
                 if (message_content[1] !== undefined && message_content[1].length > 0) // ranged roll
                 {
-                var regex = /^[0-9]+-[0-9]+$/;
+                    let regex = /^[0-9]+-[0-9]+$/;
                     if (regex.test(message_content[1])) {
-                    var range_break = message_content[1].split('-');
+                        let range_break = message_content[1].split('-');
 
                         message.channel.send(message.author + ' rolls a number between ' + range_break[0] + ' and ' + range_break[1] + '. They roll **' + numberRoll(range_break[0], range_break[1]) + '**.');
                     }
@@ -398,9 +432,9 @@ client.on('message', message => {
             case 'compute':
             case 'convert':
             case 'calculate':
-            var message_content = message.content.substring(2).split(' ');
+                let message_content = message.content.substring(2).split(' ');
                 if (message_content[1] !== undefined && message_content[1].length > 0) {
-                var response = calculate(message.content.substring(message.content.indexOf(' ') + 1));
+                    let response = calculate(message.content.substring(message.content.indexOf(' ') + 1));
                     if (response === "") {
                         response = stupidQuestion();
                     }
@@ -563,7 +597,7 @@ client.on('message', message => {
                     //message.channel.send(error.stack);
                     //message.channel.send(error.name);
                     //message.channel.send(error.message);
-                client.channels.get('357365312620068874').send(error.message);
+                    sendToBotTestingChannel(error.message);
                 }
                 break;
 
@@ -608,4 +642,5 @@ client.on('message', message => {
 ;
 
 // login
-client.login(auth.token);
+client.login(auth.token)
+    .catch(error => console.log(error));